Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

全てのエントリポイントでテストする #149

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

kamataryo
Copy link
Contributor

@kamataryo kamataryo commented Jan 27, 2022

ブラウザ/Node.js 用のエントリポイントを別々に提供していて、それぞれに異なる処理が差し込まれています。
両方ともテストして壊れていないことを確認できるように修正。

@kamataryo kamataryo changed the title Update tests 全てのエントリポイントでテストする Jan 27, 2022
@kamataryo kamataryo marked this pull request as ready for review January 27, 2022 01:32
Copy link
Member

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
テストを全部2回走らせるのはどうかなと思いましたが、念の為したほうが良さそうですね。2回めは特にキャッシュに入っているはずなので時間はそこまで影響が無いですね

@kamataryo kamataryo merged commit 896e9e0 into master Jan 27, 2022
@kamataryo kamataryo deleted the browser-testing branch January 27, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants