Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

japanese addresses側でlatとlngのデータを持っていない場合はNaNでなくnullを返す。 #171

Merged
merged 2 commits into from
May 18, 2022

Conversation

champierre
Copy link
Contributor

geolonia/japanese-addresses#93 を調査していたときに発見したバグ。

japanese addresses側でlatとlngのデータを持っていない場合はNaNでなくnullを返すべき。

keichan34
keichan34 previously approved these changes May 18, 2022
Copy link
Member

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうござました!

@kamataryo
Copy link
Contributor

ありがとうございます!
念の為 Number.isNaN(lat) で判定した方がいいかも?

@champierre
Copy link
Contributor Author

@kamataryo 修正しました。

Copy link
Contributor

@kamataryo kamataryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます 🙇

@champierre champierre merged commit 08ac919 into master May 18, 2022
@champierre champierre deleted the lat_lng_should_return_null branch May 18, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants