Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

マンション名に万・萬・億・兆が入っており、マンション名と番地の間にハイフンが入っているとクラッシュするバグの修正 #214

Conversation

RikitoNoto
Copy link
Contributor

バグ修正

以下のバグを修正しました!

原因と対策

#172 (comment)

備考

テスト項目はエラーが発生するパターンを一件追加し、そのパターン及びその他全パターンでエラーが発生しないことを確認しています。
他追加したほうが良いテストパターンがありましたらご教示いただけますと幸いです!

@phanect phanect requested a review from kamataryo July 7, 2023 12:26
@phanect phanect added the bug Something isn't working label Jul 7, 2023
Copy link
Contributor

@kamataryo kamataryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RikitoNoto ありがとうございます!取り込ませていただきます 🙇

@kamataryo kamataryo merged commit 1eb382e into geolonia:master Jul 10, 2023
9 checks passed
kamataryo added a commit that referenced this pull request Aug 31, 2023
kamataryo pushed a commit that referenced this pull request Sep 7, 2023
* Add test case with 愛知県豊田市西丹波町三五十 (#215)  and 広島県府中市栗柄町名字八五十2459 (#214)

* issue #215 fix

---------

Co-authored-by: miyabe <tatsuhiko@miya.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants