feat: 🎸 「番」の削除を末尾のみへと変更 #228
Merged
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
テストが通っていないことに気づきましたので 7754ebc のコミットで修正させていただきました よろしくお願いします |
|
@flag3 こちら、確認が遅くなり申し訳ありませんでした。 |
kamataryo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186 で言及されているビル名の「番」が消えてしまうことに関するプルリクとなります
数字+番の置換で番が末尾の場合のみ削除されるようにしました
このようにすることで「三番町ＫＳビル」や「５十五番館ビル」で番が削除されないようにしました
なお1番1号のような数字+番+数字+号といったケースは番が末尾ではないですが関係するコードの直前で1-1になるといった感じでこの変更では影響がないと考えています
よろしくお願いします