Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

テストの重複削除と、間違ったテストケース1件を修正 #232

Merged
merged 3 commits into from
Dec 5, 2023
Merged

テストの重複削除と、間違ったテストケース1件を修正 #232

merged 3 commits into from
Dec 5, 2023

Conversation

kamataryo
Copy link
Contributor

@kamataryo kamataryo commented Dec 5, 2023 •
edited

#229 で指摘いただいた内容の修正

@kamataryo kamataryo changed the title Test Refactoring テストの重複削除と、間違ったテストケース1件を修正 Dec 5, 2023
phanect
phanect suggested changes Dec 5, 2023
View reviewed changes
Copy link

@phanect phanect left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2行ほど削除しない方が良さそうな箇所を見つけました。
これ以外は問題ないと思います。

test/addresses.csv Outdated Show resolved Hide resolved
phanect
phanect approved these changes Dec 5, 2023
View reviewed changes
Copy link

@phanect phanect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kamataryo kamataryo merged commit ac298e6 into master Dec 5, 2023
9 checks passed
@kamataryo kamataryo deleted the 229-tests-refactoring branch December 5, 2023 04:55
@kamataryo kamataryo mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanect phanect phanect approved these changes

@keichan34 keichan34 Awaiting requested review from keichan34

@naogify naogify Awaiting requested review from naogify

@sugama-satsuki sugama-satsuki Awaiting requested review from sugama-satsuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

テスト項目の重複と、テスト用住所の船と舟のゆらぎ
2 participants
@kamataryo @phanect