Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

innerHTML infotip #972

Closed
dbauszus-glx opened this issue Oct 19, 2023 · 0 comments · Fixed by #976
Closed

innerHTML infotip #972

dbauszus-glx opened this issue Oct 19, 2023 · 0 comments · Fixed by #976
Assignees
Labels
Code Issues related to the code structure and performance. Feature New feature requests or changes to the behaviour or look of existing application features. Security Ticket relates to either the authentication process, security headers, and or encryption.

Comments

@dbauszus-glx
Copy link
Member

dbauszus-glx commented Oct 19, 2023

We do not want to use innerHTML within the mapp library if this can be prevented.

The infotip method should accept and check for a HTMLElement content.

A console.warning should be made if the content is not provided as HTMLElement, eg. from a plugin infotip method.

If provided as a HTMLElement this can bedirectly spliced into the node.

infotip.node = mapp.utils.html.node`<div class="infotip box-shadow">${content}`

In the featureHover.mjs method the response.label provided to the infotip method must be turned into a HTMLElement to prevent the warning from the core method.

@dbauszus-glx dbauszus-glx added Code Issues related to the code structure and performance. Security Ticket relates to either the authentication process, security headers, and or encryption. labels Oct 19, 2023
@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Oct 20, 2023
@dbauszus-glx dbauszus-glx linked a pull request Oct 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. Feature New feature requests or changes to the behaviour or look of existing application features. Security Ticket relates to either the authentication process, security headers, and or encryption.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants