Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levelset #88

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Levelset #88

wants to merge 21 commits into from

Conversation

LDTalbot
Copy link
Collaborator

@LDTalbot LDTalbot commented Feb 2, 2024

Description
Levelset method implementation with frictional barrier method via Zhao et al. (2023).

TODO

  • 2D benchmark tests for sliding block on plane.
  • 3D benchmark tests for sliding block on plane.
  • Adhesion functionality + "uphill" prevention
  • Computational speed improvements.
  • Add functionality for separate levelset mesh.
  • Write tests.
  • Add documentation: update wiki, example input files, benchmarks.

Potential Issues/Modifications

  • Parameter exploration: barrier stiffness, slip threshold, levelset MP radius (contact tolerance)
  • Potential levelset normal source of error once mesh is separate
  • RBD levelset

Related Issues

  • Contact functionality
  • Nomenclature for subclasses/derived classes: want e.g. MeshLevelset, ParticleLevelset

@LDTalbot LDTalbot added the enhancement New feature or request label Feb 2, 2024
@LDTalbot LDTalbot self-assigned this Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 15.08772% with 242 lines in your changes are missing coverage. Please review.

Project coverage is 95.23%. Comparing base (a036d3d) to head (be94707).

Current head be94707 differs from pull request most recent head d2c7d5e

Please upload reports for the commit d2c7d5e to get more accurate results.

Files Patch % Lines
include/particles/particle_levelset.tcc 0.00% 70 Missing ⚠️
include/mesh/mesh_levelset.tcc 0.00% 56 Missing ⚠️
include/io/io_mesh_ascii.tcc 8.00% 23 Missing ⚠️
include/solvers/mpm_base.tcc 47.73% 23 Missing ⚠️
include/nodes/node_levelset.tcc 0.00% 17 Missing ⚠️
include/nodes/node_base.h 0.00% 12 Missing ⚠️
include/nodes/node_levelset.h 0.00% 12 Missing ⚠️
include/contacts/contact_levelset.tcc 0.00% 11 Missing ⚠️
include/mesh/mesh_levelset.h 0.00% 5 Missing ⚠️
include/solvers/mpm_explicit.tcc 28.57% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   95.71%   95.23%   -0.48%     
==========================================
  Files         241      248       +7     
  Lines       50257    50526     +269     
==========================================
+ Hits        48101    48118      +17     
- Misses       2156     2408     +252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant