Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB GL JS pixels do not correspond to QGIS and other pixels #136

Closed
sfkeller opened this issue Nov 20, 2017 · 4 comments
Closed

MB GL JS pixels do not correspond to QGIS and other pixels #136

sfkeller opened this issue Nov 20, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@sfkeller
Copy link

When mapping MB GL JS to QGIS styles (#87) there seems to be a glitch regarding pixels values. If these pixel values are mapped 1:1 to QGIS pixels, the resulting graphic size in QGIS seems to be much larger.

The MB GL JS spec speaks of "Units in pixels", e.g. line-width (https://www.mapbox.com/mapbox-gl-js/style-spec/#layers-line ). Now, there is evidence that this is a special kind of pixel units....

Perhaps this could help? https://gis.stackexchange.com/questions/259407/style-line-width-proportionally-to-maintain-relative-size-in-mapbox-gl

Else I'd suggest to open an issue in https://github.com/mapbox/mapbox-gl-js/issues .

@sfkeller sfkeller added this to the Milestone 2 milestone Nov 20, 2017
@sfkeller sfkeller added this to In Progress in Martin's PA2 Project Nov 20, 2017
@sfkeller sfkeller changed the title MB GL JS pixels do no correspond to QGIS and other pixels MB GL JS pixels do not correspond to QGIS and other pixels Nov 20, 2017
@tomchadwin
Copy link
Contributor

This isn't a DPI/HiDPI issue is it?

@mnboos
Copy link
Collaborator

mnboos commented Nov 22, 2017

I think it's a scaling issue, resulting from my mapping "map_scale -> zoom", which seems to differ from Mapbox.

@mnboos
Copy link
Collaborator

mnboos commented Nov 24, 2017

Finally:

image

@mnboos mnboos closed this as completed Nov 24, 2017
@sfkeller sfkeller moved this from In Progress to In Review in Martin's PA2 Project Nov 26, 2017
@sfkeller sfkeller moved this from In Review to Done and Reviewed in Martin's PA2 Project Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Martin's PA2 Project
Done and Reviewed
Development

No branches or pull requests

3 participants