Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git dirtiness check & add option to ignore untracked files #225

Closed
wants to merge 1 commit into from
Closed

Conversation

dmhacker
Copy link

See #224 for a description of the issue. This pull request takes pure's approach to running status checks. I've updated the plugin README accordingly.

@jedahan
Copy link
Member

jedahan commented Oct 6, 2018

This looks good to me, gonna see if we can merge this in soon, or port it to our new architecture if that gets approved. Just didn't wanna leave you hanging on a contribution, thanks for the PR!

@jedahan
Copy link
Member

jedahan commented Jan 2, 2019

Do you have an example huge repository where this can be slow?
I'd love it if the user didn't have to think about another variable - with the right prompt being async, it shouldn't be that bad for it to be slow either way.

@jedahan jedahan mentioned this pull request Jan 6, 2019
@jedahan jedahan added this to the 2.0.0 milestone Jan 15, 2019
@jedahan
Copy link
Member

jedahan commented Aug 21, 2019

Closing in favor of the mnml branch of geometry. If it is still relevant, feel free to open and issue and I will port this PR.

@jedahan jedahan closed this Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants