Add multiline capability to geometry's prompt #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PROMPT_GEOMETRY_MULTILINE enables having geometry on multiple lines, rendering the directory and plugins all on the same line and the user prompt on a newline.
Disable RPROMPT if PROMPT_GEOMETRY_MULTILINE is set to true.
|
Thanks for making this PR. Unfortunately, we just released v2 of geometry which has a lot of changes to how things work. Would you mind starting a new PR based on the |
|
Hi @jedahan thanks for the reply! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I prefer using a multiline prompt, for example when the git branch name is too big. In this situation, I've found myself messing around with geometry in order to use separate the plugins from the user prompt.
As such, this Pull Request adds a
PROMPT_GEOMETRY_MULTILINEflag which is set tofalseby default. Changing that flag totruemakes geometry render the prompt in two lines, the first only for the directory and plugins and the second one only for the user prompt.I've used
GEOMETRY_SYMBOL_SPACERas the separator between the directory and the plugins but I don't know if this would be the best option or if it would be better to create a new variable just for this separator so I would appreciate some feedback here.Also, the contribution guide mentions updating the version but I couldn't find it anywhere except in the changelog. If I forgot to update something feel free to raise that to my attention.