Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor geometry_git_symbol into geometry_git #293

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Refactor geometry_git_symbol into geometry_git #293

merged 1 commit into from
Jan 31, 2020

Conversation

Konsonanz
Copy link
Contributor

Description

This PR refactors the geometry_git_symbol() function into the main geometry_git() function().

With the recent refactoring of printing function-output with geometry::wrap(), the array-joining in geometry_git_symbol() is now un-needed. The call to sub-functions should therefore be included in the main-function.

To-fix

The current behaviour of geometry_git_symbol() would always insert one un-needed space if only one of the called sub-functions is called. Using geometry::wrap() fixes that (please note the spacing around the "remote"-icon):
demo
I also took a look into the other functions, but found no oppurtunitys where this could also be done (I guess geometry_git_symbol() was just accidentally missed in the previous refactoring).

@jedahan
Copy link
Member

jedahan commented Jan 31, 2020

Awesome, thank you!

@jedahan jedahan merged commit b02956f into geometry-zsh:main Jan 31, 2020
@Konsonanz Konsonanz deleted the feature/wrap_git branch January 31, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants