Refactor geometry_git_symbol into geometry_git #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
geometry_git_symbol()
function into the maingeometry_git()
function().With the recent refactoring of printing function-output with
geometry::wrap()
, the array-joining ingeometry_git_symbol()
is now un-needed. The call to sub-functions should therefore be included in the main-function.To-fix
The current behaviour of
![demo](https://user-images.githubusercontent.com/46794176/73570032-7bf00500-4463-11ea-93b8-e9c581ff2056.png)
geometry_git_symbol()
would always insert one un-needed space if only one of the called sub-functions is called. Usinggeometry::wrap()
fixes that (please note the spacing around the "remote"-icon):I also took a look into the other functions, but found no oppurtunitys where this could also be done (I guess
geometry_git_symbol()
was just accidentally missed in the previous refactoring).