Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gcorso notebook submission #12

Merged
merged 14 commits into from
May 3, 2021
Merged

Added gcorso notebook submission #12

merged 14 commits into from
May 3, 2021

Conversation

gcorso
Copy link
Contributor

@gcorso gcorso commented Apr 30, 2021

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ninamiolane
Copy link
Contributor

Thank you for this great submission! 🎉

We need to fix the Travis tests before we can merge. Travis fails with this error:
ImportError: cannot import name 'mst' from 'hierarchical_clustering.relaxed.mst' (unknown location)
See here: https://travis-ci.org/github/geomstats/challenge-iclr-2021/builds/769058763

It seems that it cannot find your GitHub repository: gcorso/neural_seed.

Try replacing:
!git clone https://github.com/gcorso/neural_seed.git
with something like:
!pip install git+https://github.com/gcorso/neural_seed.git#egg=neural_seed?

@gcorso
Copy link
Contributor Author

gcorso commented May 1, 2021

Dear Nina, thank you for the suggestion, I have now fixed all the import issues (I think) but the notebook gets killed because of a period of 10min without output. However, from the error travis gives I cannot even detect the line/cell when this happens making the debugging process very hard. As can be seen executing this notebook on Google Colab hardware the notebook runs smoothly so I'm not sure where the problem lies. Do you have any suggestion on how to debug this type of issues with travis?

@gcorso
Copy link
Contributor Author

gcorso commented May 1, 2021

My current understanding is that after 10 minutes of execution (even if the notebook code prints output in its cell) the notebook is killed. Could you confirm this is the case? If so shouldn't this limit be increased given that the guidelines say that it needs to run in 3h? Thanks for the help!

@ninamiolane
Copy link
Contributor

Yes, this comes from the limitations of the Travis default settings. No problem, we will update Travis or run the notebook manually!

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging now, thank you for this great submission! 🎉 Stay tuned, as we will be in touch for the voting process.

@ninamiolane ninamiolane merged commit d9a4053 into geomstats:main May 3, 2021
@ninamiolane
Copy link
Contributor

Hi @gcorso , the voting process is now open! 🎖️ 🎖️ 🎖️

Your team can record its vote using this form: https://forms.gle/NS74g5uyzmP4wKmb9

  • Note that your team can fill this form only once. If you do not follow this rule, the vote will be cancelled.
  • The deadline to fill the form is Thursday May 6th, 11:59 am PST.
  • More details on the voting guidelines are available at the form's link above.

We look forward to deciding with you on the best open-source contributions in computational geometry and topology of the year! 🎉

@ninamiolane
Copy link
Contributor

Hi @gcorso , we have extended the deadline to submit your vote through the Google form to Thursday May 6th, 10 pm PST.

If you haven't already, you can submit your vote using the form above. Recall that you can fill out the form once per team.

If your team has already voted, feel free to ignore this message!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants