Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Submission for ICLR challenge #15

Merged
merged 9 commits into from
May 3, 2021
Merged

Conversation

s-shailja
Copy link
Contributor

@s-shailja s-shailja commented May 1, 2021

Brain connectome comparison using geodesic distances. Submitted for the ICLR challenge 2021.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ninamiolane
Copy link
Contributor

Thank you for this great submission! 🎉

We need to fix the Travis tests before we can merge. Travis fails with this error:
NameError: name 'warnings' is not defined
See here: https://travis-ci.org/github/geomstats/challenge-iclr-2021/builds/769175383

The imports need to be fixed.

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis now fails with:

ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-7b5a9e3a30b0> in <module>
      1 import numpy as np
----> 2 import networkx as nx
      3 from numpy import linalg as la
      4 import geomstats.backend as gs
      5 import csv
ModuleNotFoundError: No module named 'networkx'

see here: https://travis-ci.org/github/geomstats/challenge-iclr-2021/builds/769254576?utm_source=github_status&utm_medium=notification

You should install this package, and all the packages that you need in the notebook that are not in our requirements.txt (https://github.com/geomstats/challenge-iclr-2021/blob/main/requirements.txt), using a syntax such as:
!pip install networkx

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for fixing the tests! Submission is approved 🎉

I will let the PR opened for now, to avoid slowing down the Travis tests for the open PRs.

Thank you for the great submission, and we will be in touch for the voting process next week!

@ninamiolane ninamiolane merged commit 1b5e47e into geomstats:main May 3, 2021
@ninamiolane
Copy link
Contributor

Hi @s-shailja , the voting process is now open! 🎖️ 🎖️ 🎖️

Your team can record its vote using this form: https://forms.gle/NS74g5uyzmP4wKmb9

  • Note that your team can fill this form only once. If you do not follow this rule, the vote will be cancelled.
  • The deadline to fill the form is Thursday May 6th, 11:59 am PST.
  • More details on the voting guidelines are available at the form's link above.

We look forward to deciding with you on the best open-source contributions in computational geometry and topology of the year! 🎉

@ninamiolane
Copy link
Contributor

Hi @s-shailja , we have extended the deadline to submit your vote through the Google form to Thursday May 6th, 10 pm PST.

If you haven't already, you can submit your vote using the form above. Recall that you can fill out the form once per team.

If your team has already voted, feel free to ignore this message!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants