Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient Algorithms for Frechet Mean on Manifold of Symmetric Positive Definite Matrices #19

Merged
merged 15 commits into from
May 3, 2021

Conversation

SaitejaUtpala
Copy link
Contributor

@SaitejaUtpala SaitejaUtpala commented May 2, 2021

Efficient Algorithms for Frechet Mean on Manifold of Symmetric Positive Definite Matrices

  • Shrinkage Estimator

  • Recursive Karcher Expectation Estimator

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ninamiolane
Copy link
Contributor

Thank you for this great submission! 🎉

Travis needs to pass before we can merge. So far it is failing with:

%lprun -f kmeans.fit kmeans.fit(X)
------------------
UsageError: Could not find function 'kmeans.fit'.
NameError: name 'kmeans' is not defined

See here: https://travis-ci.org/github/geomstats/challenge-iclr-2021/builds/769243718

Probably due to commented code in your notebook. Could you look into this? Thanks!

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great submission! 🎉 Stay tuned, as we will be in touch for the voting process.

@ninamiolane ninamiolane merged commit e0f22a6 into geomstats:main May 3, 2021
@ninamiolane
Copy link
Contributor

Hi @SaitejaUtpala , the voting process is now open! 🎖️ 🎖️ 🎖️

Your team can record its vote using this form: https://forms.gle/NS74g5uyzmP4wKmb9

  • Note that your team can fill this form only once. If you do not follow this rule, the vote will be cancelled.
  • The deadline to fill the form is Thursday May 6th, 11:59 am PST.
  • More details on the voting guidelines are available at the form's link above.

We look forward to deciding with you on the best open-source contributions in computational geometry and topology of the year! 🎉

@ninamiolane
Copy link
Contributor

Hi @SaitejaUtpala , we have extended the deadline to submit your vote through the Google form to Thursday May 6th, 10 pm PST.

If you haven't already, you can submit your vote using the form above. Recall that you can fill out the form once per team.

If your team has already voted, feel free to ignore this message!

@ninamiolane
Copy link
Contributor

Hi @SaitejaUtpala , if you haven't replied yet, please check the issue #39 about asking your permission to be listed as a co-author on the challenge's white paper. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants