-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge Submission #25
Conversation
Fix the issue with getting persistence diagrams
Add the limitation of Giotto-TDA Fix some format issues
Hi @guoxiliu , thank you for this great submission! 🎉 Could you import your datasets using an external url (not uploading them on this GitHub repository)? I am afraid that Travis CI is not starting because the committed files are too large. Let me know if you encounter any problem? Thanks! :) |
Thanks for the feedback! The dataset used in the notebook is less than 10 MB, but I guess it's probably due to too many committed files. Let me try to fix the issue. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you for your reactivity! 🎉
I approve the PR, but will leave it open for now, to avoid slowing down the Travis tests for the open PRs.
Thank you for the great submission, and we will be in touch for the voting process next week!
In the notebook, we use |
No problem with this, but thank you for the notice! |
Merging now, thank you for this great submission! 🎉 Stay tuned, as we will be in touch for the voting process. |
Hi @guoxiliu , the voting process is now open! 🎖️ 🎖️ 🎖️ Your team can record its vote using this form: https://forms.gle/NS74g5uyzmP4wKmb9
We look forward to deciding with you on the best open-source contributions in computational geometry and topology of the year! 🎉 |
Hi @guoxiliu , we have extended the deadline to submit your vote through the Google form to Thursday May 6th, 10 pm PST. If you haven't already, you can submit your vote using the form above. Recall that you can fill out the form once per team. If your team has already voted, feel free to ignore this message! |
No description provided.