Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge Submission #25

Merged
merged 16 commits into from
May 3, 2021
Merged

Challenge Submission #25

merged 16 commits into from
May 3, 2021

Conversation

guoxiliu
Copy link
Contributor

@guoxiliu guoxiliu commented May 3, 2021

No description provided.

@ninamiolane
Copy link
Contributor

Hi @guoxiliu , thank you for this great submission! 🎉

Could you import your datasets using an external url (not uploading them on this GitHub repository)? I am afraid that Travis CI is not starting because the committed files are too large. Let me know if you encounter any problem? Thanks! :)

@guoxiliu
Copy link
Contributor Author

guoxiliu commented May 3, 2021

Thanks for the feedback! The dataset used in the notebook is less than 10 MB, but I guess it's probably due to too many committed files. Let me try to fix the issue.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for your reactivity! 🎉

I approve the PR, but will leave it open for now, to avoid slowing down the Travis tests for the open PRs.

Thank you for the great submission, and we will be in touch for the voting process next week!

@guoxiliu
Copy link
Contributor Author

guoxiliu commented May 3, 2021

In the notebook, we use Plotly to plot the figures (used in Giotto-TDA too), but the figures will not show in any static render of the notebooks. Will that be a problem?

@ninamiolane
Copy link
Contributor

No problem with this, but thank you for the notice!

@ninamiolane
Copy link
Contributor

Merging now, thank you for this great submission! 🎉 Stay tuned, as we will be in touch for the voting process.

@ninamiolane ninamiolane merged commit da563b5 into geomstats:main May 3, 2021
@ninamiolane
Copy link
Contributor

Hi @guoxiliu , the voting process is now open! 🎖️ 🎖️ 🎖️

Your team can record its vote using this form: https://forms.gle/NS74g5uyzmP4wKmb9

  • Note that your team can fill this form only once. If you do not follow this rule, the vote will be cancelled.
  • The deadline to fill the form is Thursday May 6th, 11:59 am PST.
  • More details on the voting guidelines are available at the form's link above.

We look forward to deciding with you on the best open-source contributions in computational geometry and topology of the year! 🎉

@ninamiolane
Copy link
Contributor

Hi @guoxiliu , we have extended the deadline to submit your vote through the Google form to Thursday May 6th, 10 pm PST.

If you haven't already, you can submit your vote using the form above. Recall that you can fill out the form once per team.

If your team has already voted, feel free to ignore this message!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants