Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission #27

Merged
merged 20 commits into from
May 3, 2021
Merged

Submission #27

merged 20 commits into from
May 3, 2021

Conversation

pikulsomesh
Copy link
Contributor

Hi
This is my submission commit.
Best
Somesh

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ninamiolane
Copy link
Contributor

Thank you for this great submission! 🎉

The Travis test needs to pass before we can merge. I think the error comes from your conda installs.

Could you try installing your packages directly in Travis, by editing the .travis.ylm file at the root of this repository (see section "install"), and removing the corresponding lines from your notebook. Thanks!

@pikulsomesh
Copy link
Contributor Author

pikulsomesh commented May 3, 2021

Hi
I have updated the .travis.yml file, and commented out the conda install in the notebook.
Could you please resolve the conflicts, or let me know if something else needs to be done?

The current conflicts in the .travis.yml file are for the 3 libraries used for processing of chemical/biological information - RDKit, MDTraj and Biopython. Please add them at your convenience.

  - conda install -c conda-forge rdkit
  - pip install biopython
  - conda install -c conda-forge mdtraj

Best
Somesh

@pikulsomesh
Copy link
Contributor Author

Hi Nina
I hope with the Travis tests done, the code runs through. I created a new environment locally, and ran it through.
One thing that I came across is that Travis has a timeout of 10 minutes. However, my code takes about an hour and half to execute.
Let me know how to address this! Should I reduce the sample size for the notebook?
Best
Somesh

@ninamiolane
Copy link
Contributor

No problem, this is a limitation of the default Travis configuration and it is on our end.

Could you resolve the GitHub conflicts in .travis.yml though? Thanks!

@pikulsomesh
Copy link
Contributor Author

Hi Nina
Thanks for confirming! I have resolved the conflicts in .travis.yml now.
Somesh

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for resolving the conflicts and thank you for this great submission! 🎉 Stay tuned, as we will be in touch for the voting process.

@ninamiolane ninamiolane merged commit ee2bd17 into geomstats:main May 3, 2021
@ninamiolane
Copy link
Contributor

Hi @pikulsomesh , the voting process is now open! 🎖️ 🎖️ 🎖️

Your team can record its vote using this form: https://forms.gle/NS74g5uyzmP4wKmb9

  • Note that your team can fill this form only once. If you do not follow this rule, the vote will be cancelled.
  • The deadline to fill the form is Thursday May 6th, 11:59 am PST.
  • More details on the voting guidelines are available at the form's link above.

We look forward to deciding with you on the best open-source contributions in computational geometry and topology of the year! 🎉

@ninamiolane
Copy link
Contributor

Hi @pikulsomesh , we have extended the deadline to submit your vote through the Google form to Thursday May 6th, 10 pm PST.

If you haven't already, you can submit your vote using the form above. Recall that you can fill out the form once per team.

If your team has already voted, feel free to ignore this message!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants