Inconsistent use of "lr" (learning rate), "step_size" and "step"

[ninamiolane]

The variables "lr" (learning rate), "step_size" and "step" are used in the API interchangeably. The variable "tau" is also introduced in Frechet mean. We should make this naming consistent, and for example:

• use "step_size" for integration schemes (because "step" is also used as a string to denote which type of step is taken, e.g. euler, rk4, etc)
• use "lr" for optimization schemes.

[nguigs]

• Do you mean that dt in integrator should be renamed step_size ?
• I find lr a bit cryptic, it should be clear that this is only an initial size that is then adapted.

[ninamiolane]

Oh I hadn't seen that we had dt too. And Ok for lr being too cryptic.

How about:

• dt in integrator.py
• step_size or initial_step_size everywhere else?

[nguigs]

I chose init_step_size because it is usually not fixed and to avoid long names