pytorch future reminder

geoopt · Mar 31, 2019 · 164a1d4 · 164a1d4
1 parent 2d47aa1
commit 164a1d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/geoopt/linalg/_expm.py b/geoopt/linalg/_expm.py
@@ -73,6 +73,7 @@ def expm_one(A):  # pragma: no cover
     U, V = torch_pade13(Ascaled)
     P = U + V
     Q = -U + V
+    # TODO: torch.gesv -> torch.solve after pytorch release
     R, _ = torch.gesv(P, Q)  # solve P = Q*R
     expmA = matrix_2_power(R, n_squarings)
     return expmA
diff --git a/geoopt/manifolds/stiefel.py b/geoopt/manifolds/stiefel.py
@@ -114,6 +114,7 @@ def _transp_follow_one(self, x, v, *, u, t):
         rhs = v + t / 2 * a @ v
         lhs = -t / 2 * a
         lhs[..., torch.arange(a.shape[-2]), torch.arange(x.shape[-2])] += 1
+        # TODO: torch.gesv -> torch.solve after pytorch release
         qv, _ = torch.gesv(rhs, lhs)
         return qv