New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve inconsistency with tensor strides and optimizer updates #71
Conversation
It seems
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just by the way... If I were doing it, I'd want to provide an explicit hint that one of the arguments is Tensor &
and not const Tensor &
, so perhaps a _
at the end: copy_or_set_()
.
is still awaiting for review
Well, really not the part that needed review
@newkozlukov, thanks, that is a better name for this. I skimmed over the codebase, looks like all critical places are covered with this function |
Thanks all |
…pt#71) * initial commit * fix typo * more efficient workaround * fix some typos * spacing in docs * update changelog * more intuitive name
Adress #70