fix NaN gradients in Sphere #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been getting the error that AcosBackward gave NaN gradients. Slightly reducing the clamping fixes the error. One might use higher precisions. I just want to mention the problem with this pull request.
|
Hmm, interesting, thanks! I think that 0.999 may be more tighter. I would suggest to check it over grid for both float 32 and 64. That's exactly the way we adjusted eps for PoincareBall. PS We did optimization with sphere manifold a lot and you are the first to meet this problem, congratulations, lucky you:) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been getting the error that AcosBackward gave NaN gradients. Slightly reducing the clamping fixes the error. One might use higher precisions. I just want to mention the problem with this pull request.