Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify euclidean manifold to support ndim argument #88

Merged
merged 5 commits into from Jul 11, 2019
Merged

unify euclidean manifold to support ndim argument #88

merged 5 commits into from Jul 11, 2019

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Jul 6, 2019

Adress #87

SomeoneSerge
SomeoneSerge reviewed Jul 10, 2019
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@ferrine ferrine merged commit d15832a into master Jul 11, 2019
@ferrine ferrine deleted the euclidean-manifold-unification branch July 11, 2019 17:11
andbloch pushed a commit to andbloch/geoopt that referenced this pull request Dec 29, 2019
@ferrine
unify euclidean manifold to support ndim argument (geoopt#88)
bd97e59 
* unify euclidean manifold to support ndim argument

* fix test

* fix typo in changelog

* move default manifold to OptimMixin

* fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneSerge SomeoneSerge SomeoneSerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferrine @SomeoneSerge