Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support reading window from local files (#86) #129

Merged
merged 4 commits into from
Apr 8, 2020
Merged

ENH: support reading window from local files (#86) #129

merged 4 commits into from
Apr 8, 2020

Conversation

darribas
Copy link
Collaborator

@darribas darribas commented Apr 7, 2020

This adds support for memory-efficient, window-based reading of local files when reset_extent=True, addressing #86, and also fixes #100 by squeezing 1-band rasters to a two-dimensional image before plotting.

@darribas darribas requested a review from ljwolf April 7, 2020 16:51
@darribas darribas added this to the 1.0 milestone Apr 7, 2020
Copy link
Member

@ljwolf ljwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good in functionality. I think we just need to remove the prints & the Polygon import!

contextily/plotting.py Outdated Show resolved Hide resolved
contextily/plotting.py Outdated Show resolved Hide resolved
@jorisvandenbossche jorisvandenbossche changed the title Fix#86 ENH: support reading window from local files (#86) Apr 8, 2020
@darribas darribas requested a review from ljwolf April 8, 2020 12:29
@coveralls
Copy link

coveralls commented Apr 8, 2020

Coverage Status

Coverage increased (+0.7%) to 93.284% when pulling 62aec89 on fix#86 into bb60619 on master.

@ljwolf ljwolf merged commit b31fd0a into master Apr 8, 2020
ljwolf added a commit to ljwolf/contextily that referenced this pull request Apr 8, 2020
ljwolf added a commit to ljwolf/contextily that referenced this pull request Apr 8, 2020
ljwolf added a commit to ljwolf/contextily that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems reading 1-band tiff locally
3 participants