add add_basemap function to new plotting.py #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does & documents #20.
A few things:
plot_with_basemap(geodataframe, ...)
function, but we'd have to decide how much to assume about the crs ofgeodataframe
. I thought it'd be more convenient to just reproject anything that's not in webmerc, but there's support elsewhere for raw lat-long.plot_map
fromplace.py
might be more properly put intoplotting.py
, orplotting.py
should be named something else.