Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency in import alias #230

Merged
merged 2 commits into from Dec 29, 2023
Merged

Fix inconsistency in import alias #230

merged 2 commits into from Dec 29, 2023

Conversation

maxdswain
Copy link
Contributor

This PR addresses the inconsistent import alias, instead of contextily being imported as ctx or cx it is now only imported as cx. This is in line with the GeoPandas documentation.

@martinfleis
Copy link
Member

@darribas Do you have a preference on this?

darribas
darribas approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@darribas darribas left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I've started using sometimes just contextily but, if it was to be abreviated, cx makes more sense to me (one les keystroke!)

@martinfleis martinfleis merged commit a8982d2 into geopandas:main Dec 29, 2023
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darribas darribas darribas approved these changes

@martinfleis martinfleis martinfleis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxdswain @martinfleis @darribas