expand retryer to include image reading #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3770fda just updates the expected values changed in the test tiles. same issue is on main, just fixing this to get green CI. irrelevant to the contents here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving image opening to the retryer in hope that it could resolve rare occasions of
UnidentifiedImageErrorpopping up. Reported in networkx/networkx#7301 and seen once in our CI (here). I wasn't able to reproduce the issue locally in any form so I am not sure if it will fix it but it is the only thing I could think of.To get a better control of retries, we should also probably expose
wait,max_retries,n_connectionsanduse_cacheonadd_basemaplevel, not only inbounds2imgbut I'll do that separately.