Initial stub on the road to address #20 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contextily/plotting.py
Outdated
| # If web source | ||
| if url[:4] == 'http': | ||
| # Zoom | ||
| if (type(zoom) == str) and (zoom.lower() == 'auto'): |
There was a problem hiding this comment.
isinstance(zoom, str) is better here
(and personally I would not do the lower, IMO no reason to give the user this flexibility)
There was a problem hiding this comment.
Addressed in 5a37032, although I've left lower as I think it's a way to be gentler with people who always forget whether it's auto, Auto, AUTO, etc.
…plotting_refactor#20
…ting deprecatin warning for plot_map
…t .tif files within the test method
|
This fails in Python 2.7, but that relates to #36. Merging to address elsewhere and also be able to implement other issues. |
darribas
changed the title
This was referenced Jul 21, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening PR to track evolution on #20. Before merging, the following needs to be completed:
add_basemapimplemented (including web and localurlsources)Place.plot_maprefactored to move plotting machinery into the newplotting.pymodule, andplotmethod inside thePlaceclass.