-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: sphinx documentation #110
Conversation
Now it works. See https://dask-geopandas--110.org.readthedocs.build/en/110/index.html We're not executing the code at the moment (we do with geopandas) and I am not sure we want to. If we do, we need to ask for a higher memory quota, otherwise, we won't even build the env. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That looks good for an initial set up of the infrastructure.
One comment: I know this is somewhat copied from geopandas, but here I would not put part of the files in another "docs" subdir (so /docs/source/docs
). As now the main page for the user guide is guide.html
, but then the subpages are docs/guide/intro.html
(which feels a bit strange, since guide.html is also part of the docs).
(in geopandas I think we did this because we also have more "non-docs" content on the website, so the docs was only one sub-part of the top-level navigation)
And I think it is fine to not execute the docs at the moment. |
That is fine for User Guide (I'll move that) but I need the same URL structure for API. Since we take docstrings from geopandas, I need the same depth from API pages to static files.
We have higher memory quota for GeoPandas from RTD. |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
I have switched the theme to |
Can we turn off execution for a specific notebook? |
For the rest looks good BTW! I think it's also fine to take this as a good start and get it merged. |
We can rely on an automatic detection of notebook to execute, so if all cells will be executed, sphinx (mys-nb) will skip it. At the moment, I have set it to "force" so yes, we can turn it off. I'll push the change in a sec to make sure it was picked up by rtd correctly |
Looks okay now. I had to specifically list it as not to be executed as the |
Thanks a lot! |
As a follow-up, we should probably update (and deduplicate) the README a bit? |
Creating sphinx documentation available at readthedocs. At the moment contains autogenerated API documentation, bits and pieces from the ReadMe and the basic intro that is now in
notebooks
.I've also slightly amended/added some docstrings.
The base for the docs (theme...) is copy&paste from GeoPandas.