Ensure spatial_partitions are properly pickled #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
commented
Feb 9, 2023
Comment on lines
+115
to
+116
| *dask_state, spatial_partitions = state | ||
| super().__setstate__(dask_state) |
There was a problem hiding this comment.
Initially, I just copied over the __setstate__ from dask.dataframe and added our state. By doing it like this (calling into super()) dask_geopandas should continue to work if Dask adds additional attributes to its state.
jsignell
approved these changes
Feb 27, 2023
martinfleis
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Thanks! @TomAugspurger does this block anything on your side? We can potentially cut 0.3.1.
|
Thanks! No, I'm able to work around it so it isn't blocking anything for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237