Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: use fixtures for accessing geopandas datasets #266

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

jorisvandenbossche
Copy link
Member

This is a (potentially temporary) solution for the geopandas datasets being deprecated / removed.

All usages have been updated to use a fixture, so we have a centralized place where the path is defined. And for now, just let that path be the old geopandas.datasets one, or the new path to the test data included in geopandas for newer versions.
Longer term, we probably ideally wouldn't rely on such internal test data of geopandas, but that's something we can clean up later.

@martinfleis
Copy link
Member

This will not work. We no longer ship the data with the package, so it is not available in installed geopandas.

@jorisvandenbossche
Copy link
Member Author

Yeah, I figured that in the meantime .. It's only the dev build here, though, and makes that I can at least already run the tests locally (with a geopandas dev build)

What do we prefer? Include the data here as well on the short term? Longer term try to replace the cities/lowres with a simple generated points and polygons dataset?

@martinfleis
Copy link
Member

We can temporarily include them here. Then I'd switch to some real-world data from geodatasets.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit fa31452 into geopandas:main Feb 28, 2024
9 of 11 checks passed
@jorisvandenbossche jorisvandenbossche deleted the test-datasets branch February 28, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants