-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy spatial_partitions
when copying GeoDataFrame
#56
Copy spatial_partitions
when copying GeoDataFrame
#56
Conversation
The behaviour follows GeoPandas' behaviour
I accidentally only included the allow_override parameter in the geoseries test
- No need to copy the dataframe, set_crs already constructs a new object - pytest.raises matching the error message
This is possibly only a short-term solution, see discussion at geopandas#55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
@DahnJ BTW, looking at the git history in this PR, you probably want to "clean up" your local master branch (it seems to include commits / merges from earlier PRs). |
Yes, you're right, I'm not sure how to "clean up" though. What operation should I perform? |
If there are no other commits on your master branch that you still want to keep / make a PR from, then you could do a full "reset" of your local master branch with upstream master (assuming this repo is called
After that, it's best to always ensure to commit your work in a new branch, and not in the master branch. And then you can keep your local master branch updated with upstream's master. |
Creates a
copy()
method that copiesspatial_partitions
, as discussed in #55