Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Python 2.6 PANDAS=master failing #271

Closed
micahcochran opened this issue Feb 9, 2016 · 4 comments
Closed

Travis Python 2.6 PANDAS=master failing #271

micahcochran opened this issue Feb 9, 2016 · 4 comments

Comments

@micahcochran
Copy link
Contributor

I made a fairly small change that I didn't think would cause this type of test failure.

Pandas has dropped support for Python 2.6 (pandas-dev/pandas#7718). Now using OrderDicts, which aren't supported by Python 2.6.

I thought I should bring this issue up before I submit a failing Pull Request. This is more important than my little PR.

Should the Python 2.6 for PANDAS master be allowed-failures or exclude it entirely?

@kjordahl
Copy link
Member

kjordahl commented Feb 9, 2016

If pandas has dropped 2.6 support, there's no point in trying to maintain it in geopandas. In the short term we can just exclude 2.6 for pandas master.

@jorisvandenbossche
Copy link
Member

It's only pandas 0.18 that drops support for python 2.6. And even when 0.18 is released, I think we should look at the dependencies of the oldest pandas version geopandas supports (you can still use geopandas with pandas 0.17, which you can still use with python 2.6)

Of course we can choose to not support 2.6 anymore anyhow, but just wanted to point out there is still some point in maintaining support :-)

@jorisvandenbossche
Copy link
Member

Sorry, I misread. Yes, indeed there is no point in keeping the test combination of python 2.6 and pandas master.

@micahcochran
Copy link
Contributor Author

Since #272 has been merged, the code no longer has issues with testing on Travis. Closing issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants