-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis Python 2.6 PANDAS=master failing #271
Comments
If pandas has dropped 2.6 support, there's no point in trying to maintain it in geopandas. In the short term we can just exclude 2.6 for pandas master. |
It's only pandas 0.18 that drops support for python 2.6. And even when 0.18 is released, I think we should look at the dependencies of the oldest pandas version geopandas supports (you can still use geopandas with pandas 0.17, which you can still use with python 2.6) Of course we can choose to not support 2.6 anymore anyhow, but just wanted to point out there is still some point in maintaining support :-) |
Sorry, I misread. Yes, indeed there is no point in keeping the test combination of python 2.6 and pandas master. |
Since #272 has been merged, the code no longer has issues with testing on Travis. Closing issue. |
I made a fairly small change that I didn't think would cause this type of test failure.
Pandas has dropped support for Python 2.6 (pandas-dev/pandas#7718). Now using OrderDicts, which aren't supported by Python 2.6.
I thought I should bring this issue up before I submit a failing Pull Request. This is more important than my little PR.
Should the Python 2.6 for PANDAS master be allowed-failures or exclude it entirely?
The text was updated successfully, but these errors were encountered: