Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add affine_transform method to GeoSeries #1008

Merged
merged 1 commit into from Jun 13, 2019
Merged

ENH: Add affine_transform method to GeoSeries #1008

merged 1 commit into from Jun 13, 2019

Conversation

donlo
Copy link
Contributor

@donlo donlo commented May 26, 2019

Attempt to address #1007

@codecov
Copy link

codecov bot commented May 26, 2019 •
edited

Codecov Report

Merging #1008 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1008      +/-   ##
=========================================
+ Coverage   88.87%   88.9%   +0.02%     
=========================================
  Files          18      18              
  Lines        1627    1631       +4     
=========================================
+ Hits         1446    1450       +4     
  Misses        181     181
Impacted Files Coverage Δ
geopandas/base.py 94.32% <100%> (+0.05%) ⬆️
geopandas/array.py 91.63% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69757af...f7c7c49. Read the comment docs.

jorisvandenbossche
jorisvandenbossche approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks perfect!

@jorisvandenbossche jorisvandenbossche merged commit 08ffc4e into geopandas:master Jun 13, 2019
@donlo
Copy link
Contributor Author

donlo commented Jun 14, 2019

Thanks for the review and merge!

@asmith26 asmith26 mentioned this pull request Jul 1, 2019
Closed
@martinfleis martinfleis mentioned this pull request Aug 18, 2019
Closed
@donlo donlo deleted the add_affine_transform_method branch September 13, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@donlo @jorisvandenbossche