Use GeocoderQueryError #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeocoderResultError no longer exists in GeocoderQueryError. Thank you for making geopandas!
|
Thanks, I think we need to decide which versions of geopy to support in GeoPandas. The geopy API seems to change quite frequently. We'll need to update the version tested on Travis CI at least. Unfortunately, the Travis setup is broken at the moment, so the test failures here are not about this issue. Working on that now. |
|
Rebased this change on master in a new branch so that it can have a proper run on Travis. I don't think it's going to work with the version of geopy we've locked to (0.96.3), but we'll see. |
Merged
|
Closing, this commit went into #108. Thanks! |
|
Cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeocoderResultError no longer exists in GeocoderQueryError. Thank you for making geopandas!