Update geoplot docs. #1044
Update geoplot docs. #1044
Conversation
There was a problem hiding this comment.
Thank you for the update. I have only a few minor comments, mostly on consistency of docs.
Generally we use import geopandas throughout or docs as it is the most straightforward. Same might apply for import geoplot and submodules (if it is not something you want to specifically use as you did).
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
======================================
Coverage 89.7% 89.7%
======================================
Files 19 19
Lines 1836 1836
======================================
Hits 1647 1647
Misses 189 189Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
======================================
Coverage 89.7% 89.7%
======================================
Files 19 19
Lines 1836 1836
======================================
Hits 1647 1647
Misses 189 189Continue to review full report at Codecov.
|
|
Thank you for updates. Merged into master. |
There was a problem hiding this comment.
@ResidentMario thanks for the updates!
small comment, will update myself in a PR as there are some other doc fixes I need to do as well
| geopandas.datasets.get_path('nyc_boroughs') | ||
| ) | ||
| collisions = geopandas.read_file( | ||
| geopandas.datasets.get_path('nyc_injurious_collisions') |
There was a problem hiding this comment.
Should this be from geoplot instead of geopandas? (and same for the one above)
There was a problem hiding this comment.
Yes, it should. 😅
I didn't rerun the script after my last change, so shame on me for failing to notice this bad copy-paste job. If you want to address this yourself that's good, otherwise I can do a quick fixer-upper PR myself.
There was a problem hiding this comment.
And shame on me that I didn't notice either and merged.
There was a problem hiding this comment.
No, no, don't blame yourself too much, just a small error :-)
Some minor renovations to the
geoplotexample gallery in the documentation necessitated by thegeoplot@0.3.0release. Also cleans up some code here or there.