New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update contextily example #1088
Conversation
Yep, you're right about the pip issue. Another option could be to mention this explicitly in the beginning (and saying that pip users can upgrade with |
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 90.2% 90.41% +0.21%
==========================================
Files 19 20 +1
Lines 1837 1878 +41
==========================================
+ Hits 1657 1698 +41
Misses 180 180
Continue to review full report at Codecov.
|
|
|
||
ax = df.plot(figsize=(10, 10), alpha=0.5, edgecolor='k') | ||
add_basemap(ax, zoom=10) | ||
ctx.add_basemap(ax, zoom=12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original example of zoom=10 gave a less detailed background, with zoom=12 it actually takes some time ..
Do you think the higher zoom is better to illustrate? (if so, the longer doc build time is fine for me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In reality, you'll rather want more detailed map than blurry one. I tried to simulate real-life use. I am aware that it takes longer, but I feel it makes more sense this way.
Updated contextily example to use
add_basemap
from contextily 1.0. However, I would wait with merging until contextily 1.0.0 is stable aspip install contextily
now installs 0.99.0 which does not work with this example.Closes #1077