Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop support for older versions of dependencies #1492

Merged
merged 6 commits into from Jul 28, 2020

Conversation

martinfleis
Copy link
Member

Updated CI and requirements as per #1457, removed compatibility layers for older pandas and fiona.

This also removes support for Python 3.5.

@martinfleis martinfleis added this to the 0.9.0 milestone Jun 28, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! (and a nice clean-up, especially for fiona ;))

One thing I am wondering: should we add a check on import if the minimum version is met?
Eg when the user has pandas < 0.24, raise a more informative import error message about GeoPandas requiring pandas >= 0.24.

For something we know will definitely fail otherwise, this might be good to do (eg for pandas, this will fail with an import error about register_extension_dtype on import of geopandas).
For ones where many functionality might still work (eg fiona), I am less sure about it.

ci/travis/36-pd024.yaml Outdated Show resolved Hide resolved
ci/travis/36-pd024.yaml Outdated Show resolved Hide resolved
@martinfleis
Copy link
Member Author

should we add a check on import if the minimum version is met?

I don't think so, normally you should not even end with such an environment, since both pip and conda resolve dependencies based on our requirements. And if you manage to do so, you should be able to figure out what is wrong I'd say.

@jorisvandenbossche
Copy link
Member

Ah, yes, for required dependencies we can indeed enforce that through installation, I forgot about that.
But you can update setup.py then:

INSTALL_REQUIRES = ["pandas >= 0.23.0", "shapely", "fiona", "pyproj >= 2.2.0"]

I was mostly thinking about how we do this in pandas, but there we have a huge number of optional dependencies, for which a version cannot be enforced in install requirements.

@martinfleis
Copy link
Member Author

But you can update setup.py

As I was changing all requirements and environments I forgot about this :). Done.

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jul 15, 2020

All good from my side. I would maybe just wait a moment with merging if we make a 0.8.1 release

@martinfleis
Copy link
Member Author

if we make a 0.8.1 release

I would do one once pickle issue is resolved.

@martinfleis
Copy link
Member Author

0.8.1 released, merging.

@martinfleis martinfleis deleted the drop_old_deps branch July 28, 2020 17:23
@jorisvandenbossche
Copy link
Member

Thanks Martin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants