New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: drop support for older versions of dependencies #1492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! (and a nice clean-up, especially for fiona ;))
One thing I am wondering: should we add a check on import if the minimum version is met?
Eg when the user has pandas < 0.24, raise a more informative import error message about GeoPandas requiring pandas >= 0.24.
For something we know will definitely fail otherwise, this might be good to do (eg for pandas, this will fail with an import error about register_extension_dtype
on import of geopandas).
For ones where many functionality might still work (eg fiona), I am less sure about it.
I don't think so, normally you should not even end with such an environment, since both pip and conda resolve dependencies based on our requirements. And if you manage to do so, you should be able to figure out what is wrong I'd say. |
Ah, yes, for required dependencies we can indeed enforce that through installation, I forgot about that. Line 32 in b0381e1
I was mostly thinking about how we do this in pandas, but there we have a huge number of optional dependencies, for which a version cannot be enforced in install requirements. |
As I was changing all requirements and environments I forgot about this :). Done. |
All good from my side. I would maybe just wait a moment with merging if we make a 0.8.1 release |
I would do one once pickle issue is resolved. |
0.8.1 released, merging. |
Thanks Martin! |
Updated CI and requirements as per #1457, removed compatibility layers for older pandas and fiona.
This also removes support for Python 3.5.