Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Warning when missing_kwds provided but no areas missing data #1600

Merged
merged 2 commits into from Sep 13, 2020
Merged

BUG: Warning when missing_kwds provided but no areas missing data #1600

merged 2 commits into from Sep 13, 2020

Conversation

gcaria
Copy link
Contributor

@gcaria gcaria commented Sep 1, 2020

Fixes #1565

As for the other pull request, any feedback is welcome since I'm a beginner.

@martinfleis martinfleis changed the title Warning when missing_kwds provided but no areas missing data BUG: Warning when missing_kwds provided but no areas missing data Sep 13, 2020
@martinfleis martinfleis merged commit 55b99c6 into geopandas:master Sep 13, 2020
@martinfleis
Copy link
Member

Thank you @gcaria!

@gcaria gcaria deleted the fix-warning-plot-empty-series branch September 14, 2020 17:43
@wahlatlas
Copy link

I'm afraid the issue isn't completely solved yet. Still (0.9.0, 0.10.2) getting the following error

Bildschirmfoto 2021-11-01 um 18 21 00

however, if I apply your fix a second time a little later in the code like this

Bildschirmfoto 2021-11-01 um 18 21 58

it plots as expected – should you need a testcase pls let me know and thanks so far

@martinfleis
Copy link
Member

@wahlatlas I have moved it to #2210. Can you provide a reproducible example in that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when missing_kwds provided but no areas missing data
3 participants