Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement legend (colorbar) for noncategorical dataframe plots #172

Closed
wants to merge 5 commits into from

Conversation

ianalis
Copy link

@ianalis ianalis commented Nov 2, 2014

This PR implements the legend option for noncategorical dataframes which, up to now, returns a NotImplementedError. Since there is no easy method of accessing the legend of an axes that I'm aware of, plot_dataframe() will also return the colorbar aside from the axes. Additional tests and appropriate changes in the documentation were also added.

@ianalis
Copy link
Author

ianalis commented Nov 2, 2014

Travis CI build failed because of ImageComparisonFailure in my new tests. Is there a way to get the generated images in the build? Obviously, the tests pass on my machine.

@jankatins
Copy link

We had similar problems in ggplot and this went away when we made some changes to the test setup:

https://github.com/yhat/ggplot/blob/master/ggplot/tests/__init__.py#L230

The problems are IMO because of difference between windows and linux/travis...

(we also copied the testing functions to get them working in earlier verisons of mpl, which didn't allow for tests outside of mpl test directory)

@coveralls
Copy link

Coverage Status

Coverage increased (+4.61%) when pulling f3b12a4 on ianalis:noncategorical-legend into cf4eb4d on geopandas:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.61%) when pulling dcb7f60 on ianalis:noncategorical-legend into cf4eb4d on geopandas:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.61%) when pulling 43333f3 on ianalis:noncategorical-legend into cf4eb4d on geopandas:master.

@ianalis
Copy link
Author

ianalis commented Nov 3, 2014

Thanks for the tip @JanSchulz. I adapted the settings from ggplot and explicitly set the sans-serif font, as well. I printed the base64-encoded failing images to download the images from travis but I removed that part when I rebased my PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.64%) when pulling 700c330 on ianalis:noncategorical-legend into cf4eb4d on geopandas:master.

@nickeubank
Copy link
Contributor

@ianalis This looks like a really nice addition -- any chance we can get this back to testing clean? We're hoping to (finally) get release 0.2 in the next month or two, and this would be a great addition.

@IamJeffG
Copy link
Contributor

#267 includes a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants