New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement legend (colorbar) for noncategorical dataframe plots #172
Conversation
Travis CI build failed because of |
We had similar problems in ggplot and this went away when we made some changes to the test setup: https://github.com/yhat/ggplot/blob/master/ggplot/tests/__init__.py#L230 The problems are IMO because of difference between windows and linux/travis... (we also copied the testing functions to get them working in earlier verisons of mpl, which didn't allow for tests outside of mpl test directory) |
f3b12a4
to
dcb7f60
Compare
dcb7f60
to
43333f3
Compare
Thanks for the tip @JanSchulz. I adapted the settings from ggplot and explicitly set the sans-serif font, as well. I printed the base64-encoded failing images to download the images from travis but I removed that part when I rebased my PR. |
@ianalis This looks like a really nice addition -- any chance we can get this back to testing clean? We're hoping to (finally) get release 0.2 in the next month or two, and this would be a great addition. |
#267 includes a fix for this issue. |
This PR implements the
legend
option for noncategorical dataframes which, up to now, returns aNotImplementedError
. Since there is no easy method of accessing the legend of an axes that I'm aware of,plot_dataframe()
will also return the colorbar aside from the axes. Additional tests and appropriate changes in the documentation were also added.