Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in sjoin index #191

Merged
merged 7 commits into from Apr 29, 2015
Merged

Fix bug in sjoin index #191

merged 7 commits into from Apr 29, 2015

Conversation

kjordahl
Copy link
Member

Fix for second issue mentioned in #190.

@kjordahl kjordahl mentioned this pull request Apr 28, 2015
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.15% when pulling e22d654 on bug/sjoin-index into c4d56a3 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.15% when pulling e22d654 on bug/sjoin-index into c4d56a3 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.15% when pulling e22d654 on bug/sjoin-index into c4d56a3 on master.

@kjordahl kjordahl mentioned this pull request Apr 28, 2015
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.15% when pulling a1988eb on bug/sjoin-index into c4d56a3 on master.

@kjordahl
Copy link
Member Author

Pushed my suggested fix from #190, should now cover both bugs reported there. @jkosir can you confirm that this fixes your issue?

Also cleaned up a few minor things in the same file.

@jkosir
Copy link

jkosir commented Apr 29, 2015

Yep, this fixes #190 for me.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 91.14% when pulling 15b2b45 on bug/sjoin-index into c4d56a3 on master.

kjordahl added a commit that referenced this pull request Apr 29, 2015
@kjordahl
Merge pull request #191 from geopandas/bug/sjoin-index
2c883c8 
Fix bug in sjoin index
@kjordahl kjordahl merged commit 2c883c8 into master Apr 29, 2015
@kjordahl kjordahl deleted the bug/sjoin-index branch April 30, 2015 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjordahl @coveralls @jkosir