DEP: bump required versions of dependecies #2358
Conversation
|
I think that we're hitting #1697 in environments coming from |
|
And why are we getting |
|
I think we should be fine now. A few observation as it was not as easy as I thought.
|
| @@ -922,7 +909,8 @@ def test_estimate_utm_crs__geographic(self): | |||
| self.landmarks.estimate_utm_crs() | |||
| else: | |||
| assert self.landmarks.estimate_utm_crs() == CRS("EPSG:32618") | |||
| assert self.landmarks.estimate_utm_crs("NAD83") == CRS("EPSG:26918") | |||
| if compat.PYPROJ_GE_32: # result is unstable in older pyproj | |||
| assert self.landmarks.estimate_utm_crs("NAD83") == CRS("EPSG:26918") | |||
There was a problem hiding this comment.
Didn't we test with such older version before, or is it triggered due to the combo with a certain fiona install?
There was a problem hiding this comment.
No. We tested with 2.2 which skipped the whole test and latest. I have added 3.1 which causes the issue #2045
There was a problem hiding this comment.
Thanks a lot! Looks good, one more thing: can you also update the documentation? (https://geopandas.org/en/latest/getting_started/install.html#dependencies)
Forgot about that one :). Fixed. |
Can be removed as geopandas#2358 bumped shapely to ">= 1.7"
* TST: Add test for rectangle clipping * ENH: Add `GeometryArray().clip_by_rect()` * ENH: Add `GeoPandasBase().clip_by_rect()` Closes #1902 * Change signatures to use tuple rectangle * Change signatures to use tuple rectangle * Raise exception when shapely < 1.7 Exception is raised as `shapely.ops.clip_by_rect` was introduced in shapely 1.7 * Reorder tests to make them easier to group * Parameterize all test which use single_rectangle_df to also test with bounds * Paramterize test with larger single rectangle * Add bounding box clip capability to clip using .clip_by_rect() * Add documentation for `.clip_by_rect()` and changes in `clip()` * Skip clip tests if shapely < 1.7 * Improve test coverage * Remove shapely >1.7 compatibility checks Can be removed as #2358 bumped shapely to ">= 1.7" * Apply suggestions from code review Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net> * Only check for empty geometries after `.clip_by_rect()` * Move changes to `clip.py` to its own PR * Change docstring of `base.clip_by_rect()` according to PR comments * add interpshinx links Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Bumping required versions of dependencies following the rules defined in #1457 and removed now obsolete compatibility code.