Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Add direct references to fiona docs in read_file #2460

Merged
merged 2 commits into from Aug 4, 2022
Merged

DOC: Add direct references to fiona docs in read_file #2460

merged 2 commits into from Aug 4, 2022

Conversation

snowman2
Copy link
Contributor

@snowman2 snowman2 commented Jun 11, 2022 •
edited

This adds links to the fiona documentation with intersphinx.

@snowman2 snowman2 force-pushed the fiona_intersphinx branch 2 times, most recently from d7494a2 to de0ad9f Compare June 11, 2022 03:16
@snowman2 snowman2 changed the title CI: Add direct references to fiona docs in read_file DOC: Add direct references to fiona docs in read_file Jun 11, 2022
@snowman2
Copy link
Contributor Author

Failure is unrelated to this PR.

martinfleis
martinfleis approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also added the same for pyogrio to have the docstring consistent.

@martinfleis martinfleis merged commit dde3b4d into geopandas:main Aug 4, 2022
@snowman2 snowman2 deleted the fiona_intersphinx branch August 4, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snowman2 @martinfleis