Update minimum package dependencies #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
approved these changes
Sep 8, 2023
jorisvandenbossche
approved these changes
Sep 13, 2023
|
Thanks both! |
JohnMoutafis
pushed a commit
to JohnMoutafis/geopandas
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
m-richards
added a commit
to m-richards/geopandas
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it might be a good idea to update our dependencies if we're aiming to do a release soonish. This is based on the SPEC 0 time windows, and I used a modified version of the included code snippet (https://gist.github.com/m-richards/ea4a156b702b27641d81c32d195dfc98) to work out the package ranges. Note that it's not perfect (fiona 1.8.20 is missing for some reason) but it's certainly easier than manually checking pypi for everything.
The only variation I've made is for fiona, where I've updated the dependency range taking into account micro releases, since there were so many 1.8.x releases.
I just touched the dependencies which affect our code and those specified in the CI envs, except I left pyarrow, mapclassify and the sql related dependencies.
We can also potentially reduce the number of CI envs, as we have a lot of 3.9 environments after this, but I think that would be easier to review as a separate pull request.