Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Expose transform #3075

Merged
merged 5 commits into from Dec 22, 2023
Merged

ENH: Expose transform #3075

merged 5 commits into from Dec 22, 2023

Conversation

JohnMoutafis
Copy link
Contributor

Exposes Shapely's transform function according to ENH: #2010

martinfleis
martinfleis reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking great! I've left a few minor suggestions.

Can you also add it to doc/source/docs/reference/geoseries.rst to be included in docs and add a note to the changelog.md?

geopandas/base.py Outdated Show resolved Hide resolved
geopandas/base.py Outdated Show resolved Hide resolved
geopandas/base.py Outdated Show resolved Hide resolved
geopandas/tests/test_geom_methods.py Show resolved Hide resolved
@martinfleis martinfleis added this to the 1.0 milestone Nov 20, 2023
@martinfleis martinfleis mentioned this pull request Nov 20, 2023
Open
57 tasks
@JohnMoutafis
Copy link
Contributor Author

@martinfleis I have updated my branch according to your suggestions!

m-richards
m-richards approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@m-richards m-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohnMoutafis, looking good to me. Will wait and see if Martin has anything further to add before merging.

martinfleis
martinfleis approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit efde071 into geopandas:main Dec 22, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@m-richards m-richards m-richards approved these changes

Assignees
No one assigned
Labels
enhancement shapely parity
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnMoutafis @martinfleis @m-richards