ENH: include coverage_union_all in union_all and dissolve #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
changed the title
57 tasks
There was a problem hiding this comment.
Thanks @martinfleis , this seems like a better way to expose coverage_union_all from Shapely.
A few docstring suggestions...
geopandas/base.py
Outdated
| Parameters | ||
| ---------- | ||
| coverage : bool (default False) | ||
| Whether to assume non-overlapping coverage and opt-in for the faster |
There was a problem hiding this comment.
Suggest using the same docstring as below
If True, will use the faster coverage union to merge geometries.
If False, the default slower but robust union will be used.
|
Change the keyword to |
Co-authored-by: Brendan Ward <bcward@astutespruce.com>
m-richards
approved these changes
Feb 18, 2024
Co-authored-by: Matt Richards <45483497+m-richards@users.noreply.github.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
… into coverage_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xref #2010
I was surprised how faster this actually is. On geodatasets'
geoda.southit goes from 121 ms to 4.43 ms. It will likely depend on the data but it is impressive nonetheless.The formulations in the docstring feel a bit sloppy so I'd appreciate some native speaker to check if it makes sense.