ENH: GeoArrow import #3301
ENH: GeoArrow import #3301
Conversation
There was a problem hiding this comment.
Two minor notes regarding publicity of the helper functions.
Otherwise it looks okay to my eyes with a big caveat that I am unable to verify arrow-specific parts of the code. Maybe @kylebarron can help out here?
| return None | ||
|
|
||
|
|
||
| def arrow_to_geopandas(table, geometry=None): |
There was a problem hiding this comment.
Is this intentionally public function? All the other IO helpers are considered private.
There was a problem hiding this comment.
Nothing in this file is public, so maybe we should start with the habit of naming the file with an underscore then?
(by using no underscore for this function, there is some distinction in this file between what are purely helpers only used in this file, and what are the functions actually used elsewhere)
But can certainly just add a underscore for now ;)
There was a problem hiding this comment.
Nothing in this file is public, so maybe we should start with the habit of naming the file with an underscore then?
yeah, but there's no indication of that as of now :). Naming the files with an underscore will help, if you want to keep function names without.
There was a problem hiding this comment.
+1 on making the file name private
| return GeoDataFrame(df, geometry=geometry or geom_fields[0][1]) | ||
|
|
||
|
|
||
| def arrow_to_geometry_array(arr): |
There was a problem hiding this comment.
Same here. Shouldn't this be private?
geopandas/io/geoarrow.py
Outdated
|
|
||
| Specifically for GeoSeries.from_arrow. | ||
| """ | ||
| schema_capsule, _ = arr.__arrow_c_array__() |
There was a problem hiding this comment.
You might want to use this approach instead: https://github.com/developmentseed/lonboard/blob/5812fcc4957f84436a97c79580cddcff25655f31/lonboard/_viz.py#L434-L460
This only imports the array once instead of twice, which may be preferred in the case that there's some costly transformation to geoarrow.
| @@ -425,6 +549,9 @@ def construct_shapely_array(arr: pa.Array, extension_name: str): | |||
| with GeoArrow extension type. | |||
|
|
|||
| """ | |||
| if isinstance(arr, pa.ExtensionArray): | |||
| arr = arr.storage | |||
There was a problem hiding this comment.
arr.storage is guaranteed to always exist on pa.ExtensionArray? That's not added by geoarrow-pyarrow, right?
There was a problem hiding this comment.
arr.storageis guaranteed to always exist onpa.ExtensionArray?
Indeed, that is defined in pyarrow on the base class
|
Failure is a "urllib.error.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>", so going to assume this is not related. |
Counterpart of #3219 for import Arrow data, adding
from_arrowclass method to GeoSeries/GeoDataFrame (mimicking other constructor methods we have likefrom_wkb)