BUG: allow appending df with no CRS to postgis with no CRS #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-ys-tan
commented
Jun 6, 2024
nicholas-ys-tan
force-pushed
the
issue2158
branch
from
0b1a2ee
to
d2cc50a
Compare
martinfleis
approved these changes
Jun 6, 2024
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small one to close out #2158, #2763, and stale MR #2159
Changing the default no CRS value to 0 to be consistent with postgis. There are a few different proposed approaches to this floating about the above issues/PRs, but this one is based on the comments in #2159 . It is not clear to me why -1 was selected as the no CRS value in the first place, so I may be missing some important context.
EDIT
Looking at shapely.get_srid(), it returns a -1 if it is run on None, but 0 when on a geometry with no CRS. The docstring does only specify -1 for 'not-a-geometry value' but does not specify 0 is the no CRS value. Perhaps this misinterpretation was the origin of using -1 as the no CRS value here?
Closes #2158, closes #2763, closes #2159