Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of C++ Node (CPU+GPU) Pytorch Agent Tutorial #2552

Draft
wants to merge 75 commits into
base: dev
Choose a base branch
from
Draft

Addition of C++ Node (CPU+GPU) Pytorch Agent Tutorial #2552

wants to merge 75 commits into from

Conversation

lhlawson
Copy link
Contributor

@lhlawson lhlawson commented Aug 12, 2022 •
edited

This PR introduces:

  1. A new C++ GEOPM agent capable of loading the CPU & GPU NN models provided by Addition of C++ GPU Pytorch Agent Tutorial #2146 and Addition of C++ CPU Pytorch Agent Tutorial  #2217
  2. Experiment scripts to launch the node_torch agent against GPU workloads

Todo:

  • Integration testing

Dependencies:

lhlawson and others added 30 commits August 10, 2022 17:40
@lhlawson
First pass C++ pytorch inference agent
8054b68 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
First pass update of process_gpu_frequency_sweep.py
27a63ef 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
misc naming convention updates
1f9c98c 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Moved to a NN per GPU, added CPU signals for future CPU NN work
e828b58 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Added a quick README.md
b60b8c0 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Removed debug print
b12af1e 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Agent cleanup, moved to dataloader, and updated normalization to batc…
4381f3f 
…hnorm1d

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Debug message updates, batch size increase
f6e6b93 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Moved agent from general format to specific approach
bca3ed3 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
updated training eval prints
74e4eb1 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
README and naming convention updates
60ec9ea 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Updated README paths, removed phi0.policy in favor of generation usin…
76c1385 
…g geopmagent tool

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
reverting GEOPM back to C++11 std
7561b30 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Name updates, README updates, removal of redundant process_gpu_freque…
9f1299b 
…ncy_sweep.py

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
removed erroneous comments
00de092 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
License header exemption for pytorch tutorial
85e71ad 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Added pytorch_agent tutorial to Makefile
a549d03 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
updated README with correct policy and agent name
1e85542 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@dannosliwcd @lhlawson
gpu sweep processing script from tensorflow tutorial copied for pytor…
7acfd52 
…ch tutorial modifications

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
processing script signal name updates and handling added for per-gpu …
f84e19a 
…vs all-gpu energy

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Further README updates after review
a6f8567 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
moved GEOPM_PLUGIN_PATH to export
2a7a578 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Copyright header update
413ba4c 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Added inf handling to gpu training
b0df18a 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Update to leave one out code & testing of leave one out apps
8730402 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@avilcheslopez @lhlawson
Minor fixes in process_gpu_frequency_sweep script
ec8b52b 
Fixes to account for changes in report naming scheme/pattern.

Signed-off-by: Alejandro Vilches <alejandro.vilches@intel.com>
@lhlawson
Rebased & updated to GEOPM 2.0 naming conventions. Added GPU offload …
42a80b3 
…for training

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Force CPU device for model export
cca2f24 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>

Documentation & license update

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>

Use proper device for test set

Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
License fixup
b36fc2a 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
torch.device fixup
6fb4cfa 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Update to leave one out code & testing of leave one out apps
9f890f0 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Fixed accuracy print, added accuracy +/- tolerance print
f094d02 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Removed phi linearization, covered in later commit
2194740 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Rename for GEOPM 2.0, added cpu training offload to cuda devices
51e3f1d 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Updated test set to use proper device
a4dd9a6 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
License Update
2b77ae6 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
torch device fixup
1b6e142 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Updated temperature signal to 2.0 convention
d3f7210 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Update CPUTorchAgent.cpp with new CPU_INST* naming for signals
9b5e4e1 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Update to MIN/MAX_AVAIL naming for frequency limits
07184d1 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Added CPU Torch Experiments
0f45b8a 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Updated agent policy
9b8ef77 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Signal name update for pytorch CPU agent & scripts
870141f 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Pulled in ENV based model loading, change min/max signal usage
701efba 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Script changes for integration testing
a13e67c 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Added test_cpu_torch_agent integration test
3f45fe4 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Removed GPU code to decouple PRs
84860af 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Updated test_cpu_torch_agent integration test
653c293 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Added check for workload availability
a80969c 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Fixed Makefile tutorial dists
6228540 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@lhlawson
Updated NodeTorchAgent based on GPU & CPU Agent clean-up
58497b0 
Signed-off-by: Lowren Lawson <lowren.h.lawson@intel.com>
@lhlawson
Added GPU Torch Agent code
016672f 
Signed-off-by: Lowren Lawson <lowren.h.lawson@intel.com>
@lhlawson
Readme Cleanup
4fa4e90 
Signed-off-by: Lowren Lawson <lowren.h.lawson@intel.com>
@lhlawson
Added basic experiment scripts for node_torch agent
e2a02aa 
Signed-off-by: Lowren Lawson <lowren.h.lawson@intel.com>
@lhlawson lhlawson force-pushed the public-lhlawson-pytorch-tutorial-node branch from ba6e132 to 8d351c4 Compare August 13, 2022 22:22
@lhlawson
Updated experiment scripts and added integration test
8d351c4 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lhlawson @dannosliwcd @avilcheslopez