Added some missing tests to FFNet and DebugIOGroup. Fixed tabs. #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmaalrawi
force-pushed
the
ahalrawi/ahalrawi-ffnet-coverage
branch
from
68e3dbb
to
a7fa8be
Compare
bgeltz
reviewed
May 16, 2024
libgeopm/test/DomainNetMapTest.cpp
Outdated
Comment on lines
84
to
91
| GEOPM_EXPECT_THROW_MESSAGE( | ||
| DomainNetMapImp(M_FILENAME, | ||
| GEOPM_DOMAIN_PACKAGE, | ||
| 0, | ||
| m_fake_plat_io, | ||
| m_fake_nn_factory), | ||
| GEOPM_ERROR_INVALID, | ||
| "Unable to open neural net file"); |
There was a problem hiding this comment.
Suggested change
| GEOPM_EXPECT_THROW_MESSAGE( | |
| DomainNetMapImp(M_FILENAME, | |
| GEOPM_DOMAIN_PACKAGE, | |
| 0, | |
| m_fake_plat_io, | |
| m_fake_nn_factory), | |
| GEOPM_ERROR_INVALID, | |
| "Unable to open neural net file"); | |
| GEOPM_EXPECT_THROW_MESSAGE( | |
| DomainNetMapImp(M_FILENAME, GEOPM_DOMAIN_PACKAGE, 0, | |
| m_fake_plat_io, m_fake_nn_factory), | |
| GEOPM_ERROR_INVALID, "Unable to open neural net file"); |
asmaalrawi
force-pushed
the
ahalrawi/ahalrawi-ffnet-coverage
branch
from
19f3f00
to
7b016fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some minor code coverage gaps. Some formatting nitpicks.