add points_from_xy to GeoSeries class
#214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsutterley
changed the title
point_from_xy to GeoSeries classpoints_from_xy to GeoSeries class
kylebarron
reviewed
Mar 22, 2023
| @@ -205,6 +205,29 @@ def geoarrow_coords_to_numpy(struct_array: pyarrow.StructArray): | |||
|
|
|||
| raise ValueError() | |||
|
|
|||
| @classmethod | |||
| def points_from_xy(cls, x, y, | |||
| z: Iterable | pl.Series | None = None, | |||
There was a problem hiding this comment.
None of the underlying geo algorithms support 3-dimensional data at this point, so my inclination was to not try to support 3d coordinates.
kylebarron
reviewed
Mar 22, 2023
| @@ -205,6 +205,29 @@ def geoarrow_coords_to_numpy(struct_array: pyarrow.StructArray): | |||
|
|
|||
| raise ValueError() | |||
|
|
|||
| @classmethod | |||
| def points_from_xy(cls, x, y, | |||
There was a problem hiding this comment.
I think you also want the type hints on x and y? Note that Iterable | pl.Series is a strict subset of what you can pass into pyarrow.StructArray; it also accepts numpy arrays and pyarrow arrays I think
|
Thanks for the PR! I'm not exactly sure at a glance why CI is now failing. Regardless I think you might need to apply |
remove z coordinates (unsupported) black formatting of `geoseries.py` add typing for x and y coordinates
|
Removing z makes things simpler :) |
seems like the pattern is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallels function of same name in GeoPandas for creating a GeoSeries from in-memory arrays