Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex geometries can generate a large number of cad guides #267

Open
megawac opened this issue Aug 23, 2023 · 1 comment · May be fixed by #271
Open

Complex geometries can generate a large number of cad guides #267

megawac opened this issue Aug 23, 2023 · 1 comment · May be fixed by #271

Comments

@megawac
Copy link
Contributor

megawac commented Aug 23, 2023

Problem

As guides are generated by the edges of features registered for snapping, when map features have any complexity they can result in a large number of guides being generated. As shown in the image below, 2 features can generate a large number of lines (in the image 10). In our application we have seen in real maps 50+ lines being generated using nbClosestFeatures: 5. In cases like this the guides are essentially meaningless.

image

Proposal

Add a new option (limitGuidesFromFeature) to the cad control which provides the user the ability to limit the number of features that can be generated from any given feature. For example, you might limit the number of lines that can be possibly generated from a feature to 3; we would then limit the number of lines added to the map to the 3 most proximal to the users cursor. This way, there will be a hard maximum of lines ever shown on the users screen to nbClosestFeatures times the limitGuidesFromFeature.

(This is the strategy I plan to implement in my companies fork of the project, we will be happy to submit the implementation if this sounds reasonable).

@oterral
Copy link
Contributor

oterral commented May 10, 2024

@megawac it sounds reasonable. Feel free to propose a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants